Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c8e30c1

Browse filesBrowse files
cjihrigtargos
authored andcommitted
src: fix -Wsign-compare warnings
This commit addresses the following compilation warnings: ../src/node_crypto.cc:5053:3: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare] CHECK_EQ(n, BN_bn2binpad(r, data, n)); ../src/node_crypto.cc:5054:3: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare] CHECK_EQ(n, BN_bn2binpad(s, data + n, n)); PR-URL: #30565 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
1 parent f24f352 commit c8e30c1
Copy full SHA for c8e30c1

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎src/node_crypto.cc‎

Copy file name to clipboardExpand all lines: src/node_crypto.cc
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5047,8 +5047,8 @@ static AllocatedBuffer ConvertSignatureToP1363(Environment* env,
50475047

50485048
const BIGNUM* r = ECDSA_SIG_get0_r(asn1_sig);
50495049
const BIGNUM* s = ECDSA_SIG_get0_s(asn1_sig);
5050-
CHECK_EQ(n, BN_bn2binpad(r, data, n));
5051-
CHECK_EQ(n, BN_bn2binpad(s, data + n, n));
5050+
CHECK_EQ(n, static_cast<unsigned int>(BN_bn2binpad(r, data, n)));
5051+
CHECK_EQ(n, static_cast<unsigned int>(BN_bn2binpad(s, data + n, n)));
50525052

50535053
ECDSA_SIG_free(asn1_sig);
50545054

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.