Commit c8aa08e
n-api: return napi_invalid_arg on napi_create_bigint_words
N-API statuses shall be preferred over throwing JavaScript Errors on
checks occurred in N-APIs.
PR-URL: #31312
Refs: #29849
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent e1fd6ae commit c8aa08eCopy full SHA for c8aa08e
File tree
Expand file treeCollapse file tree
2 files changed
+4
-6
lines changedOpen diff view settings
Filter options
- src
- test/js-native-api/test_bigint
Expand file treeCollapse file tree
2 files changed
+4
-6
lines changedOpen diff view settings
Collapse file
+2-4Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1596 | 1596 | |
1597 | 1597 | |
1598 | 1598 | |
1599 | | - |
1600 | | - |
1601 | | - |
1602 | | - |
| 1599 | + |
| 1600 | + |
1603 | 1601 | |
1604 | 1602 | |
1605 | 1603 | |
|
Collapse file
test/js-native-api/test_bigint/test.js
Copy file name to clipboardExpand all lines: test/js-native-api/test_bigint/test.js+2-2Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
40 | 40 | |
41 | 41 | |
42 | 42 | |
43 | | - |
44 | | - |
| 43 | + |
| 44 | + |
45 | 45 | |
0 commit comments