Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit c8a3b2d

Browse filesBrowse files
joyeecheunggibfahn
joyeecheung
authored and
gibfahn
committed
build: run linter before running tests
PR-URL: #16284 Fixes: https://github.com/node/issues/16283 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
1 parent d185bfd commit c8a3b2d
Copy full SHA for c8a3b2d

File tree

Expand file treeCollapse file tree

1 file changed

+13
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+13
-1
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+13-1Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,15 +213,26 @@ test: all
213213
$(MAKE) build-addons
214214
$(MAKE) build-addons-napi
215215
$(MAKE) doc-only
216+
$(MAKE) lint
216217
$(MAKE) cctest
217218
$(PYTHON) tools/test.py --mode=release -J \
218219
$(CI_ASYNC_HOOKS) \
219220
$(CI_JS_SUITES) \
220221
$(CI_NATIVE_SUITES) \
221222
doctool known_issues
222-
$(MAKE) lint
223223
endif
224224

225+
# For a quick test, does not run linter or build doc
226+
test-only: all
227+
$(MAKE) build-addons
228+
$(MAKE) build-addons-napi
229+
$(MAKE) cctest
230+
$(PYTHON) tools/test.py --mode=release -J \
231+
$(CI_ASYNC_HOOKS) \
232+
$(CI_JS_SUITES) \
233+
$(CI_NATIVE_SUITES) \
234+
known_issues
235+
225236
test-cov: all
226237
$(MAKE) build-addons
227238
$(MAKE) build-addons-napi
@@ -1107,6 +1118,7 @@ endif
11071118
test-gc \
11081119
test-gc-clean \
11091120
test-hash-seed \
1121+
test-only \
11101122
test-v8 \
11111123
test-v8-all \
11121124
test-v8-benchmarks \

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.