Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c84b420

Browse filesBrowse files
addaleaxcodebytere
authored andcommitted
Revert "net: partially revert "simplify Socket.prototype._final""
This reverts commit ac1f56c. Refs: #24288 Refs: #24075 PR-URL: #24290 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
1 parent 0f6a952 commit c84b420
Copy full SHA for c84b420

File tree

Expand file treeCollapse file tree

1 file changed

+0
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-6
lines changed
Open diff view settings
Collapse file

‎lib/net.js‎

Copy file name to clipboardExpand all lines: lib/net.js
-6Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -349,12 +349,6 @@ Socket.prototype._final = function(cb) {
349349
return this.once('connect', () => this._final(cb));
350350
}
351351

352-
// TODO(addaleax): This should not be necessary.
353-
if (!this.readable || this._readableState.ended) {
354-
cb();
355-
return this.destroy();
356-
}
357-
358352
if (!this._handle)
359353
return cb();
360354

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.