Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c782c3d

Browse filesBrowse files
KrayzeeKevdanielleadams
authored andcommitted
test: ensure NODE_EXTRA_CA_CERTS not set before tests
The 'test-tls-env-extra-ca-file-load.js' test assumes that NODE_EXTRA_CA_CERTS is not set. If the build environment happens to have it set, this test will fail. This change deletes that env var before running the test. PR-URL: #43858 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent c9ecd6d commit c782c3d
Copy full SHA for c782c3d

File tree

Expand file treeCollapse file tree

1 file changed

+2
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-0
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-tls-env-extra-ca-file-load.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tls-env-extra-ca-file-load.js
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ if (process.argv[2] !== 'child') {
2020
const NODE_EXTRA_CA_CERTS = fixtures.path('keys', 'ca1-cert.pem');
2121
const extendsEnv = (obj) => ({ ...process.env, ...obj });
2222

23+
// Remove any pre-existing extra CA certs.
24+
delete process.env.NODE_EXTRA_CA_CERTS;
2325
[
2426
extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'yes', NODE_EXTRA_CA_CERTS }),
2527
extendsEnv({ CHILD_USE_EXTRA_CA_CERTS: 'no' }),

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.