Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c77b0da

Browse filesBrowse files
cjihrigRafaelGSS
authored andcommitted
test: fix flaky test-runner-exit-code.js
test/parallel/test-runner-exit-code.js failed in a recent CI run with the following error: + actual - expected + 'TAP version 13\n' + + '# Subtest: /home/iojs/build/workspace/...' - 'TAP version 13\n' This commit resolves that flakiness. Refs: https://ci.nodejs.org/job/node-test-commit-linuxone/35759/ PR-URL: #46138 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent f050889 commit c77b0da
Copy full SHA for c77b0da

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-runner-exit-code.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-runner-exit-code.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ async function runAndKill(file) {
2020
});
2121
const [code, signal] = await once(child, 'exit');
2222
await finished(child.stdout);
23-
assert.match(stdout, /not ok 1/);
24-
assert.match(stdout, /# cancelled 1\n/);
23+
assert(stdout.startsWith('TAP version 13\n'));
2524
assert.strictEqual(signal, null);
2625
assert.strictEqual(code, 1);
2726
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.