Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit c76f214

Browse filesBrowse files
TrottMyles Borins
Trott
authored and
Myles Borins
committed
test,tools: enable linting for undefined vars
The test directory had linting for undefined variables disabled. It is enabled everywhere else in the code base. Let's disable the fule for individual lines in the handful of tests that use undefined variables. PR-URL: #6255 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
1 parent 24ac16f commit c76f214
Copy full SHA for c76f214
Expand file treeCollapse file tree

13 files changed

+19
-26
lines changed
Open diff view settings
Collapse file

‎test/.eslintrc‎

Copy file name to clipboardExpand all lines: test/.eslintrc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
## Test-specific linter rules
22

33
rules:
4-
## allow undeclared variables
5-
no-undef: 0
64
## common module is mandatory in tests
75
required-modules: [2, "common"]
86

Collapse file

‎test/message/nexttick_throw.js‎

Copy file name to clipboardExpand all lines: test/message/nexttick_throw.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ process.nextTick(function() {
55
process.nextTick(function() {
66
process.nextTick(function() {
77
process.nextTick(function() {
8+
// eslint-disable-next-line
89
undefined_reference_error_maker;
910
});
1011
});
Collapse file

‎test/message/timeout_throw.js‎

Copy file name to clipboardExpand all lines: test/message/timeout_throw.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,6 @@
22
require('../common');
33

44
setTimeout(function() {
5+
// eslint-disable-next-line no-undef
56
undefined_reference_error_maker;
67
});
Collapse file

‎test/parallel/test-domain-exit-dispose-again.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-domain-exit-dispose-again.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ setTimeout(function firstTimer() {
5656
// Make V8 throw an unreferenced error. As a result, the domain's error
5757
// handler is called, which disposes the domain "d" and should prevent the
5858
// nested timer that is attached to it from running.
59-
err3();
59+
err3(); // eslint-disable-line no-undef
6060
});
6161
}, TIMEOUT_DURATION);
6262

Collapse file

‎test/parallel/test-domain-exit-dispose.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-domain-exit-dispose.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ function err() {
2929
});
3030

3131
// this function doesn't exist, and throws an error as a result.
32-
err3();
32+
err3(); // eslint-disable-line no-undef
3333
}
3434

3535
function handle(e) {
Collapse file

‎test/parallel/test-exception-handler2.js‎

Copy file name to clipboard
+5-13Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,14 @@
11
'use strict';
2-
require('../common');
3-
var assert = require('assert');
2+
const common = require('../common');
43

54
process.on('uncaughtException', function(err) {
65
console.log('Caught exception: ' + err);
76
});
87

9-
var timeoutFired = false;
10-
setTimeout(function() {
8+
setTimeout(common.mustCall(function() {
119
console.log('This will still run.');
12-
timeoutFired = true;
13-
}, 500);
14-
15-
process.on('exit', function() {
16-
assert.ok(timeoutFired);
17-
});
10+
}), 50);
1811

1912
// Intentionally cause an exception, but don't catch it.
20-
nonexistentFunc();
21-
console.log('This will not run.');
22-
13+
nonexistentFunc(); // eslint-disable-line no-undef
14+
common.fail('This will not run.');
Collapse file

‎test/parallel/test-global.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-global.js
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,14 @@ var assert = require('assert');
44

55
common.globalCheck = false;
66

7-
baseFoo = 'foo';
7+
baseFoo = 'foo'; // eslint-disable-line no-undef
88
global.baseBar = 'bar';
99

1010
assert.equal('foo', global.baseFoo, 'x -> global.x in base level not working');
1111

12-
assert.equal('bar', baseBar, 'global.x -> x in base level not working');
12+
assert.equal('bar',
13+
baseBar, // eslint-disable-line no-undef
14+
'global.x -> x in base level not working');
1315

1416
var module = require('../fixtures/global/plain');
1517
const fooBar = module.fooBar;
Collapse file

‎test/parallel/test-http-exceptions.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-exceptions.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var common = require('../common');
33
var http = require('http');
44

55
var server = http.createServer(function(req, res) {
6-
intentionally_not_defined();
6+
intentionally_not_defined(); // eslint-disable-line no-undef
77
res.writeHead(200, {'Content-Type': 'text/plain'});
88
res.write('Thank you, come again.');
99
res.end();
Collapse file

‎test/parallel/test-listen-fd-cluster.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-listen-fd-cluster.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ if (common.isWindows) {
2121
switch (process.argv[2]) {
2222
case 'master': return master();
2323
case 'worker': return worker();
24-
case 'parent': return parent();
2524
}
2625

2726
var ok;
Collapse file

‎test/parallel/test-next-tick-errors.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-next-tick-errors.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ let exceptionHandled = false;
1010
process.nextTick(function() {
1111
order.push('A');
1212
// cause an error
13-
what();
13+
what(); // eslint-disable-line no-undef
1414
});
1515

1616
// This nextTick function should remain in the queue when the first one

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.