Commit c60d87b
test: don't connect to :: (use localhost instead)
If a test does http.listen(0) or net.listen(0),
http.listen(0).address().address returns '::'. Some machines will
resolve this to localhost, but not all. Every machine should have
localhost defined in /etc/hosts (or equivalent), so it should always
resolve.
Fixes: #7291
PR-URL: #10854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>1 parent 3642f35 commit c60d87bCopy full SHA for c60d87b
File tree
Expand file treeCollapse file tree
2 files changed
+2
-4
lines changedOpen diff view settings
Filter options
- test
- gc
- parallel
Expand file treeCollapse file tree
2 files changed
+2
-4
lines changedOpen diff view settings
Collapse file
test/gc/test-net-timeout.js
Copy file name to clipboardExpand all lines: test/gc/test-net-timeout.js+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
36 | 36 | |
37 | 37 | |
38 | 38 | |
39 | | - |
| 39 | + |
40 | 40 | |
41 | 41 | |
42 | 42 | |
|
Collapse file
test/parallel/test-http-status-reason-invalid-chars.js
Copy file name to clipboardExpand all lines: test/parallel/test-http-status-reason-invalid-chars.js+1-3Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
3 | 3 | |
4 | 4 | |
5 | 5 | |
6 | | - |
7 | 6 | |
8 | 7 | |
9 | 8 | |
| ||
34 | 33 | |
35 | 34 | |
36 | 35 | |
37 | | - |
38 | | - |
| 36 | + |
39 | 37 | |
40 | 38 | |
41 | 39 | |
|
0 commit comments