Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c60d87b

Browse filesBrowse files
gibfahnItalo A. Casas
authored andcommitted
test: don't connect to :: (use localhost instead)
If a test does http.listen(0) or net.listen(0), http.listen(0).address().address returns '::'. Some machines will resolve this to localhost, but not all. Every machine should have localhost defined in /etc/hosts (or equivalent), so it should always resolve. Fixes: #7291 PR-URL: #10854 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michal Zasso <targos@protonmail.com>
1 parent 3642f35 commit c60d87b
Copy full SHA for c60d87b

File tree

Expand file treeCollapse file tree

2 files changed

+2
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-4
lines changed
Open diff view settings
Collapse file

‎test/gc/test-net-timeout.js‎

Copy file name to clipboardExpand all lines: test/gc/test-net-timeout.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function getall() {
3636
if (count >= todo)
3737
return;
3838

39-
const req = net.connect(server.address().port, server.address().address);
39+
const req = net.connect(server.address().port);
4040
req.resume();
4141
req.setTimeout(10, function() {
4242
req.destroy();
Collapse file

‎test/parallel/test-http-status-reason-invalid-chars.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-status-reason-invalid-chars.js
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
const common = require('../common');
44
const assert = require('assert');
55
const http = require('http');
6-
const net = require('net');
76

87
function explicit(req, res) {
98
assert.throws(() => {
@@ -34,8 +33,7 @@ const server = http.createServer((req, res) => {
3433
implicit(req, res);
3534
}
3635
}).listen(0, common.mustCall(() => {
37-
const addr = server.address().address;
38-
const hostname = net.isIPv6(addr) ? `[${addr}1]` : addr;
36+
const hostname = 'localhost';
3937
const url = `http://${hostname}:${server.address().port}`;
4038
let left = 2;
4139
const check = common.mustCall((res) => {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.