Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c568dfa

Browse filesBrowse files
Trottevanlucas
authored andcommitted
test: refactor pummel/test-dtrace-jsstack
* `os.type()` check -> `common.isSunOS` * != -> !== * == -> === PR-URL: #8175 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent cfbafd7 commit c568dfa
Copy full SHA for c568dfa

File tree

Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Collapse file

‎test/pummel/test-dtrace-jsstack.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-dtrace-jsstack.js
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const common = require('../common');
33
var assert = require('assert');
44
var os = require('os');
55

6-
if (os.type() != 'SunOS') {
6+
if (!common.isSunOS) {
77
common.skip('no DTRACE support');
88
return;
99
}
@@ -52,7 +52,7 @@ dtrace.stdout.on('data', function(data) {
5252
});
5353

5454
dtrace.on('exit', function(code) {
55-
if (code != 0) {
55+
if (code !== 0) {
5656
console.error('dtrace exited with code ' + code);
5757
process.exit(code);
5858
}
@@ -65,7 +65,7 @@ dtrace.on('exit', function(code) {
6565
for (var i = 0; i < lines.length; i++) {
6666
var line = lines[i];
6767

68-
if (line.indexOf(sentinel) == -1 || frames.length === 0)
68+
if (line.indexOf(sentinel) === -1 || frames.length === 0)
6969
continue;
7070

7171
var frame = line.substr(line.indexOf(sentinel) + sentinel.length);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.