Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit c5181ed

Browse filesBrowse files
danbevMyles Borins
danbev
authored and
Myles Borins
committed
build: reduce noise from doc target
The doc target currently echos the complete shell command, which might produces a lot of output. Using this change the actual commands run are still shown. Before: [ -e tools/doc/node_modules/js-yaml/package.json ] || \ [ -e tools/eslint/node_modules/js-yaml/package.json ] || \ if [ -x ./node ]; then \ cd tools/doc && ../.././node ../.././deps/npm/bin/npm-cli.js install; \ else \ cd tools/doc && node ../.././deps/npm/bin/npm-cli.js install; \ fi [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md After: [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md To verify run: $ make docclean $ make doc PR-URL: #9457 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
1 parent d3c25c1 commit c5181ed
Copy full SHA for c5181ed

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ out/doc/%: doc/%
284284
# check if ./node is actually set, else use user pre-installed binary
285285
gen-json = tools/doc/generate.js --format=json $< > $@
286286
out/doc/api/%.json: doc/api/%.md
287-
[ -e tools/doc/node_modules/js-yaml/package.json ] || \
287+
@[ -e tools/doc/node_modules/js-yaml/package.json ] || \
288288
[ -e tools/eslint/node_modules/js-yaml/package.json ] || \
289289
if [ -x $(NODE) ]; then \
290290
cd tools/doc && ../../$(NODE) ../../$(NPM) install; \
@@ -296,7 +296,7 @@ out/doc/api/%.json: doc/api/%.md
296296
# check if ./node is actually set, else use user pre-installed binary
297297
gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html --template=doc/template.html $< > $@
298298
out/doc/api/%.html: doc/api/%.md
299-
[ -e tools/doc/node_modules/js-yaml/package.json ] || \
299+
@[ -e tools/doc/node_modules/js-yaml/package.json ] || \
300300
[ -e tools/eslint/node_modules/js-yaml/package.json ] || \
301301
if [ -x $(NODE) ]; then \
302302
cd tools/doc && ../../$(NODE) ../../$(NPM) install; \

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.