Commit c4fc1ff
test: fix flaky async-hooks/test-zlib.zlib-binding.deflate
Previously, the typed arrays used in this test would not
automatically be kept alive by the native handle when
it’s using them, so the V8 garbage collector could collect
them while they are still in use by the zlib module,
leading to memory corruption.
Fixes: #20907
PR-URL: #21077
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 44fe78b commit c4fc1ffCopy full SHA for c4fc1ff
File tree
Expand file treeCollapse file tree
1 file changed
+16
-7
lines changedOpen diff view settings
Filter options
- test/async-hooks
Expand file treeCollapse file tree
1 file changed
+16
-7
lines changedOpen diff view settings
Collapse file
test/async-hooks/test-zlib.zlib-binding.deflate.js
Copy file name to clipboardExpand all lines: test/async-hooks/test-zlib.zlib-binding.deflate.js+16-7Lines changed: 16 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
21 | 21 | |
22 | 22 | |
23 | 23 | |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
24 | 33 | |
25 | 34 | |
26 | 35 | |
27 | 36 | |
28 | 37 | |
29 | | - |
| 38 | + |
30 | 39 | |
31 | | - |
| 40 | + |
32 | 41 | |
33 | 42 | |
34 | 43 | |
35 | | - |
36 | | - |
37 | | - |
38 | 44 | |
39 | 45 | |
40 | | - |
| 46 | + |
41 | 47 | |
42 | 48 | |
43 | 49 | |
44 | 50 | |
45 | 51 | |
46 | 52 | |
47 | 53 | |
48 | | - |
| 54 | + |
49 | 55 | |
50 | 56 | |
51 | 57 | |
| ||
61 | 67 | |
62 | 68 | |
63 | 69 | |
| 70 | + |
| 71 | + |
| 72 | + |
64 | 73 | |
0 commit comments