Commit c44db7f
test: fix flaky test-worker-debug
Address a race condition in the test; the Worker’s exit events
may have been not recorded because the Worker exited before
the listeners were attached.
Fix the by attaching the event listeners before telling the Worker
to exit.
PR-URL: #28307
Fixes: #28299
Fixes: #28106
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>1 parent dd53e6a commit c44db7fCopy full SHA for c44db7f
File tree
Expand file treeCollapse file tree
2 files changed
+8
-4
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
2 files changed
+8
-4
lines changedOpen diff view settings
Collapse file
test/parallel/parallel.status
Copy file name to clipboardExpand all lines: test/parallel/parallel.status-2Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
21 | 21 | |
22 | 22 | |
23 | 23 | |
24 | | - |
25 | | - |
26 | 24 | |
27 | 25 | |
28 | 26 | |
|
Collapse file
test/parallel/test-worker-debug.js
Copy file name to clipboardExpand all lines: test/parallel/test-worker-debug.js+8-2Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
240 | 240 | |
241 | 241 | |
242 | 242 | |
| 243 | + |
| 244 | + |
| 245 | + |
| 246 | + |
| 247 | + |
| 248 | + |
243 | 249 | |
244 | 250 | |
245 | | - |
| 251 | + |
246 | 252 | |
247 | | - |
| 253 | + |
248 | 254 | |
249 | 255 | |
250 | 256 | |
|
0 commit comments