Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c1aa5f0

Browse filesBrowse files
Trottaddaleax
authored andcommitted
test: tune test-uv-threadpool-schedule
test-uv-threadpool-schedule has been failing consistently in node-daily-master CI. It also fails consistently on my personal laptop. These changes make it pass consistently with current master but fail consistently with Node.js 10.11 (which was the last release in the 10.x line before the fix that the test is for). It succeeds/fails as expected whether or not I am connected to the network. Fixes: #25305 PR-URL: #25358 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 5b93356 commit c1aa5f0
Copy full SHA for c1aa5f0

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎test/internet/test-uv-threadpool-schedule.js‎

Copy file name to clipboardExpand all lines: test/internet/test-uv-threadpool-schedule.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ function onResolve() {
3131
'fast I/O was throttled due to threadpool congestion.');
3232

3333
// More realistic expectation: finish disc I/O at least within
34-
// a time duration that is 1/100th of net I/O.
34+
// a time duration that is half of net I/O.
3535
// Ideally the slow I/O should not affect the fast I/O as those
3636
// have two different thread-pool buckets. However, this could be
3737
// highly load / platform dependent, so don't be very greedy.
3838
const fastIOtime = fastIOend - start;
3939
const slowIOtime = slowIOend - start;
40-
const expectedMax = slowIOtime / 100;
40+
const expectedMax = slowIOtime / 2;
4141
assert.ok(fastIOtime < expectedMax,
4242
'fast I/O took longer to complete, ' +
4343
`actual: ${fastIOtime}, expected: ${expectedMax}`);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.