Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c03bd57

Browse filesBrowse files
bnoordhuisMyles Borins
authored andcommitted
src: check uv_async_init() return value
Pointed out by Coverity. PR-URL: #7374 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 1baa145 commit c03bd57
Copy full SHA for c03bd57

File tree

Expand file treeCollapse file tree

2 files changed

+6
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+6
-6
lines changed
Open diff view settings
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3857,9 +3857,9 @@ void Init(int* argc,
38573857

38583858
// init async debug messages dispatching
38593859
// Main thread uses uv_default_loop
3860-
uv_async_init(uv_default_loop(),
3861-
&dispatch_debug_messages_async,
3862-
DispatchDebugMessagesAsyncCallback);
3860+
CHECK_EQ(0, uv_async_init(uv_default_loop(),
3861+
&dispatch_debug_messages_async,
3862+
DispatchDebugMessagesAsyncCallback));
38633863
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));
38643864

38653865
#if defined(NODE_V8_OPTIONS)
Collapse file

‎src/node_win32_etw_provider.cc‎

Copy file name to clipboardExpand all lines: src/node_win32_etw_provider.cc
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,9 @@ void init_etw() {
155155
event_write = (EventWriteFunc)GetProcAddress(advapi, "EventWrite");
156156

157157
// create async object used to invoke main thread from callback
158-
uv_async_init(uv_default_loop(),
159-
&dispatch_etw_events_change_async,
160-
etw_events_change_async);
158+
CHECK_EQ(0, uv_async_init(uv_default_loop(),
159+
&dispatch_etw_events_change_async,
160+
etw_events_change_async));
161161
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_etw_events_change_async));
162162

163163
if (event_register) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.