Commit bff201a
util: remove unreachable defensive coding
Now that we are using primordials in the first part of
isIdenticalTypedArrayType(), the defensive coding to get the correct
result (when Symbol.toStringTag is manipulated) is no longer reachable
or necessary. Remove the code.
Refs: https://coverage.nodejs.org/coverage-873d21cdc1266273/lib/internal/util/comparisons.js.html#L135
PR-URL: #36744
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 8f672eb commit bff201aCopy full SHA for bff201a
File tree
Expand file treeCollapse file tree
1 file changed
+3
-42
lines changedOpen diff view settings
Filter options
- lib/internal/util
Expand file treeCollapse file tree
1 file changed
+3
-42
lines changedOpen diff view settings
Collapse file
lib/internal/util/comparisons.js
Copy file name to clipboardExpand all lines: lib/internal/util/comparisons.js+3-42Lines changed: 3 additions & 42 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
44 | 44 | |
45 | 45 | |
46 | 46 | |
47 | | - |
48 | | - |
49 | | - |
50 | | - |
51 | | - |
52 | | - |
53 | | - |
54 | | - |
55 | | - |
56 | 47 | |
57 | 48 | |
58 | 49 | |
| ||
126 | 117 | |
127 | 118 | |
128 | 119 | |
129 | | - |
130 | | - |
131 | | - |
132 | | - |
133 | | - |
134 | | - |
135 | | - |
136 | | - |
137 | | - |
138 | | - |
139 | | - |
140 | | - |
141 | | - |
142 | | - |
143 | | - |
144 | | - |
145 | | - |
146 | | - |
147 | | - |
148 | | - |
149 | | - |
150 | | - |
151 | | - |
152 | | - |
153 | | - |
154 | | - |
155 | | - |
156 | | - |
157 | | - |
158 | | - |
159 | | - |
160 | | - |
161 | 120 | |
162 | 121 | |
163 | 122 | |
| ||
241 | 200 | |
242 | 201 | |
243 | 202 | |
244 | | - |
| 203 | + |
| 204 | + |
245 | 205 | |
| 206 | + |
246 | 207 | |
247 | 208 | |
248 | 209 | |
|
0 commit comments