Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bfe0b46

Browse filesBrowse files
tniessendanielleadams
authored andcommitted
src: simplify calls to BN_bin2bn in prime gen
PR-URL: #37169 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 745aad7 commit bfe0b46
Copy full SHA for bfe0b46

File tree

Expand file treeCollapse file tree

1 file changed

+4
-12
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-12
lines changed
Open diff view settings
Collapse file

‎src/crypto/crypto_random.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_random.cc
+4-12Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -104,29 +104,21 @@ Maybe<bool> RandomPrimeTraits::AdditionalConfig(
104104
bool safe = args[offset + 1]->IsTrue();
105105

106106
if (!args[offset + 2]->IsUndefined()) {
107-
params->add.reset(BN_secure_new());
107+
ArrayBufferOrViewContents<unsigned char> add(args[offset + 2]);
108+
params->add.reset(BN_bin2bn(add.data(), add.size(), nullptr));
108109
if (!params->add) {
109110
THROW_ERR_CRYPTO_OPERATION_FAILED(env, "could not generate prime");
110111
return Nothing<bool>();
111112
}
112-
ArrayBufferOrViewContents<unsigned char> add(args[offset + 2]);
113-
if (BN_bin2bn(add.data(), add.size(), params->add.get()) == nullptr) {
114-
THROW_ERR_INVALID_ARG_VALUE(env, "invalid options.add");
115-
return Nothing<bool>();
116-
}
117113
}
118114

119115
if (!args[offset + 3]->IsUndefined()) {
120-
params->rem.reset(BN_secure_new());
116+
ArrayBufferOrViewContents<unsigned char> rem(args[offset + 3]);
117+
params->rem.reset(BN_bin2bn(rem.data(), rem.size(), nullptr));
121118
if (!params->rem) {
122119
THROW_ERR_CRYPTO_OPERATION_FAILED(env, "could not generate prime");
123120
return Nothing<bool>();
124121
}
125-
ArrayBufferOrViewContents<unsigned char> rem(args[offset + 3]);
126-
if (BN_bin2bn(rem.data(), rem.size(), params->rem.get()) == nullptr) {
127-
THROW_ERR_INVALID_ARG_VALUE(env, "invalid options.rem");
128-
return Nothing<bool>();
129-
}
130122
}
131123

132124
int bits = static_cast<int>(size);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.