Commit bf9a52c
src: prevent changing FunctionTemplateInfo after publish
Refs https://chromium-review.googlesource.com/c/v8/v8/+/2718147
Fixes an issue where Node.js tries to call SetClassName on a
FunctionTemplate twice in some cases. The above CL made it so that
V8 CHECKs when this occurs. It is fixed by ensuring SetClassName
is only called once.
PR-URL: #46979
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 9962459 commit bf9a52cCopy full SHA for bf9a52c
File tree
Expand file treeCollapse file tree
2 files changed
+8
-3
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
2 files changed
+8
-3
lines changedOpen diff view settings
Collapse file
+3-1Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
345 | 345 | |
346 | 346 | |
347 | 347 | |
348 | | - |
| 348 | + |
| 349 | + |
349 | 350 | |
350 | 351 | |
351 | 352 | |
| ||
371 | 372 | |
372 | 373 | |
373 | 374 | |
| 375 | + |
374 | 376 | |
375 | 377 | |
376 | 378 | |
|
Collapse file
+5-2Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1496 | 1496 | |
1497 | 1497 | |
1498 | 1498 | |
1499 | | - |
| 1499 | + |
| 1500 | + |
| 1501 | + |
1500 | 1502 | |
1501 | 1503 | |
1502 | 1504 | |
1503 | 1505 | |
1504 | 1506 | |
1505 | | - |
| 1507 | + |
| 1508 | + |
1506 | 1509 | |
1507 | 1510 | |
1508 | 1511 | |
|
0 commit comments