Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bf88328

Browse filesBrowse files
richardlauBethGriggs
authored andcommitted
doc: add updating expected assets to release guide
Add a section to the Major Releases section of the release guide to cover updating the list of expected files for the promotion tool. PR-URL: #40470 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
1 parent d64cf17 commit bf88328
Copy full SHA for bf88328

File tree

Expand file treeCollapse file tree

1 file changed

+11
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+11
-0
lines changed
Open diff view settings
Collapse file

‎doc/guides/releases.md‎

Copy file name to clipboardExpand all lines: doc/guides/releases.md
+11Lines changed: 11 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -900,6 +900,15 @@ test, or doc-related are to be listed as notable changes. Some SEMVER-MINOR
900900
commits may be listed as notable changes on a case-by-case basis. Use your
901901
judgment there.
902902

903+
### Update the expected assets
904+
905+
The promotion script does a basic check that the expected files are present.
906+
Open a pull request in the Build repository to add the list of expected files
907+
for the new release line as a new file, `v{N}.x` (where `{N}` is the major
908+
version of the release), in the [expected assets][] folder. The change will
909+
need to be deployed onto the web server by a member of the [build-infra team][]
910+
before the release is promoted.
911+
903912
### Snap
904913

905914
The Node.js [Snap][] package has a "default" for installs where the user hasn't
@@ -914,5 +923,7 @@ take place once a new LTS line has been released.
914923
[Node.js Snap management repository]: https://github.com/nodejs/snap
915924
[Partner Communities]: https://github.com/nodejs/community-committee/blob/HEAD/governance/PARTNER_COMMUNITIES.md
916925
[Snap]: https://snapcraft.io/node
926+
[build-infra team]: https://github.com/orgs/nodejs/teams/build-infra
927+
[expected assets]: https://github.com/nodejs/build/tree/HEAD/ansible/www-standalone/tools/promote/expected_assets
917928
[nodejs.org release-post.js script]: https://github.com/nodejs/nodejs.org/blob/HEAD/scripts/release-post.js
918929
[nodejs.org repository]: https://github.com/nodejs/nodejs.org

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.