Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bf7aa9f

Browse filesBrowse files
committed
deps: silence irrelevant V8 warnings
PR-URL: #37587 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent eac377b commit bf7aa9f
Copy full SHA for bf7aa9f

File tree

Expand file treeCollapse file tree

2 files changed

+3
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+3
-4
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.6',
39+
'v8_embedder_string': '-node.7',
4040

4141
##### V8 defaults for Node.js #####
4242

Collapse file

‎deps/v8/include/v8.h‎

Copy file name to clipboardExpand all lines: deps/v8/include/v8.h
+2-3Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1653,7 +1653,7 @@ class V8_EXPORT Module : public Data {
16531653
*/
16541654
int GetIdentityHash() const;
16551655

1656-
using ResolveCallback V8_DEPRECATE_SOON("Use ResolveModuleCallback") =
1656+
using ResolveCallback =
16571657
MaybeLocal<Module> (*)(Local<Context> context, Local<String> specifier,
16581658
Local<Module> referrer);
16591659
using ResolveModuleCallback = MaybeLocal<Module> (*)(
@@ -7287,8 +7287,7 @@ using CallCompletedCallback = void (*)(Isolate*);
72877287
* fails (e.g. due to stack overflow), the embedder must propagate
72887288
* that exception by returning an empty MaybeLocal.
72897289
*/
7290-
using HostImportModuleDynamicallyCallback V8_DEPRECATE_SOON(
7291-
"Use HostImportModuleDynamicallyWithImportAssertionsCallback instead") =
7290+
using HostImportModuleDynamicallyCallback =
72927291
MaybeLocal<Promise> (*)(Local<Context> context,
72937292
Local<ScriptOrModule> referrer,
72947293
Local<String> specifier);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.