Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit be8d934

Browse filesBrowse files
Trottdanielleadams
authored andcommitted
tools: remove exception for Node.js 8 and earlier
Remove exception in .eslintrc.js to accommodate versions of Node.js prior to 10.x. 10.x and later all support omitting catch block arguments. PR-URL: #38840 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 6986154 commit be8d934
Copy full SHA for be8d934

File tree

Expand file treeCollapse file tree

1 file changed

+1
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-4
lines changed
Open diff view settings
Collapse file

‎.eslintrc.js‎

Copy file name to clipboardExpand all lines: .eslintrc.js
+1-4Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,7 @@ Module._findPath = (request, paths, isMain) => {
2525
if (!r && hacks.includes(request)) {
2626
try {
2727
return require.resolve(`./tools/node_modules/${request}`);
28-
// Keep the variable in place to ensure that ESLint started by older Node.js
29-
// versions work as expected.
30-
// eslint-disable-next-line no-unused-vars
31-
} catch (e) {
28+
} catch {
3229
return require.resolve(
3330
`./tools/node_modules/eslint/node_modules/${request}`);
3431
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.