Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit be62037

Browse filesBrowse files
sam-githubMylesBorins
sam-github
authored and
MylesBorins
committed
src: describe what NODE_MODULE_VERSION is for
Current comment described what to do with it when the ABI changes, but implied that Node.js would load modules with newer ABI numbers, which it will not. PR-URL: #10414 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent d260fb2 commit be62037
Copy full SHA for be62037

File tree

Expand file treeCollapse file tree

1 file changed

+3
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-0
lines changed
Open diff view settings
Collapse file

‎src/node_version.h‎

Copy file name to clipboardExpand all lines: src/node_version.h
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@
4747
(minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION))
4848

4949
/**
50+
* Node.js will refuse to load modules that weren't compiled against its own
51+
* module ABI number, exposed as the process.versions.modules property.
52+
*
5053
* When this version number is changed, node.js will refuse
5154
* to load older modules. This should be done whenever
5255
* an API is broken in the C++ side, including in v8 or

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.