Commit bdf933b
buffer: changing let in for loops back to var
Using let in for loops showed a regression in 4.4.0. @ofrobots
suggested that we avoid using let in for loops until TurboFan becomes
the default optimiser.
The regression that was detected was when looking at how long it took
to create a new buffer from an array of data.
When using `for (let i=0; i<length; i++) ` we saw the operation take
almost 40% longer compared to `var i=0`.
PR-URL: #5819
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Trevor Norris <trevnorris@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Ref: http://github.com/nodejs/benchmarking/issues/381 parent 2cbbaaf commit bdf933bCopy full SHA for bdf933b
File tree
Expand file treeCollapse file tree
1 file changed
+4
-3
lines changedOpen diff view settings
Filter options
- lib
Expand file treeCollapse file tree
1 file changed
+4
-3
lines changedOpen diff view settings
Collapse file
+4-3Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
165 | 165 | |
166 | 166 | |
167 | 167 | |
168 | | - |
| 168 | + |
169 | 169 | |
170 | 170 | |
171 | 171 | |
| ||
256 | 256 | |
257 | 257 | |
258 | 258 | |
| 259 | + |
259 | 260 | |
260 | 261 | |
261 | 262 | |
| ||
264 | 265 | |
265 | 266 | |
266 | 267 | |
267 | | - |
| 268 | + |
268 | 269 | |
269 | 270 | |
270 | 271 | |
271 | 272 | |
272 | 273 | |
273 | 274 | |
274 | 275 | |
275 | | - |
| 276 | + |
276 | 277 | |
277 | 278 | |
278 | 279 | |
|
0 commit comments