Commit bdcf8f4
test: fix test/pummel/test-fs-watch-file.js
test-fs-watch-file.js fails for two reasons. First, there are cases
where it is checking the error message for an error whose message has
changed since the test was written. Change these instances to check for
an error code instead.
Second, there is an instance where it tries to remove a listener but
fails because `common.mustNotCall()` returns a differnet instance of a
function on each call. Store the function in a variable name so it can
be removed as a listener on a file.
PR-URL: #25384
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent be16cc9 commit bdcf8f4Copy full SHA for bdcf8f4
File tree
Expand file treeCollapse file tree
1 file changed
+7
-14
lines changedOpen diff view settings
Filter options
- test/pummel
Expand file treeCollapse file tree
1 file changed
+7
-14
lines changedOpen diff view settings
Collapse file
test/pummel/test-fs-watch-file.js
Copy file name to clipboardExpand all lines: test/pummel/test-fs-watch-file.js+7-14Lines changed: 7 additions & 14 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
60 | 60 | |
61 | 61 | |
62 | 62 | |
63 | | - |
64 | | - |
65 | | - |
66 | | - |
67 | | - |
68 | | - |
| 63 | + |
| 64 | + |
69 | 65 | |
70 | 66 | |
71 | 67 | |
| ||
84 | 80 | |
85 | 81 | |
86 | 82 | |
87 | | - |
88 | | - |
89 | | - |
90 | | - |
91 | | - |
92 | | - |
| 83 | + |
| 84 | + |
93 | 85 | |
94 | 86 | |
95 | 87 | |
| ||
114 | 106 | |
115 | 107 | |
116 | 108 | |
117 | | - |
| 109 | + |
| 110 | + |
118 | 111 | |
119 | | - |
| 112 | + |
120 | 113 | |
121 | 114 | |
122 | 115 | |
|
0 commit comments