Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bdaac04

Browse filesBrowse files
cjihrigMylesBorins
authored andcommitted
wasi: improve use of primordials
PR-URL: #31212 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent f7833ac commit bdaac04
Copy full SHA for bdaac04

File tree

Expand file treeCollapse file tree

1 file changed

+6
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-7
lines changed
Open diff view settings
Collapse file

‎lib/wasi.js‎

Copy file name to clipboardExpand all lines: lib/wasi.js
+6-7Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
/* global WebAssembly */
33
const {
44
ArrayIsArray,
5-
ArrayPrototypeForEach,
65
ArrayPrototypeMap,
6+
ArrayPrototypePush,
77
FunctionPrototypeBind,
8-
ObjectKeys,
8+
ObjectEntries,
99
Symbol,
1010
} = primordials;
1111

@@ -40,7 +40,7 @@ class WASI {
4040
for (const key in env) {
4141
const value = env[key];
4242
if (value !== undefined)
43-
envPairs.push(`${key}=${value}`);
43+
ArrayPrototypePush(envPairs, `${key}=${value}`);
4444
}
4545
} else if (env !== undefined) {
4646
throw new ERR_INVALID_ARG_TYPE('options.env', 'Object', env);
@@ -49,10 +49,9 @@ class WASI {
4949
const preopenArray = [];
5050

5151
if (typeof preopens === 'object' && preopens !== null) {
52-
ArrayPrototypeForEach(ObjectKeys(preopens), (key) => {
53-
preopenArray.push(String(key));
54-
preopenArray.push(String(preopens[key]));
55-
});
52+
for (const [key, value] of ObjectEntries(preopens)) {
53+
ArrayPrototypePush(preopenArray, String(key), String(value));
54+
}
5655
} else if (preopens !== undefined) {
5756
throw new ERR_INVALID_ARG_TYPE('options.preopens', 'Object', preopens);
5857
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.