Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bd3cef7

Browse filesBrowse files
Trottaddaleax
authored andcommitted
test: use mustCall() in pummel test
Replace 'exit' check with common.mustCall(). PR-URL: #34327 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 0ede223 commit bd3cef7
Copy full SHA for bd3cef7

File tree

Expand file treeCollapse file tree

1 file changed

+2
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-5
lines changed
Open diff view settings
Collapse file

‎test/pummel/test-net-connect-econnrefused.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-net-connect-econnrefused.js
+2-5Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,14 @@ function pummel() {
4848
}
4949

5050
function check() {
51-
setTimeout(function() {
51+
setTimeout(common.mustCall(function() {
5252
assert.strictEqual(process._getActiveRequests().length, 0);
5353
const activeHandles = process._getActiveHandles();
5454
assert.ok(activeHandles.every((val) => val.constructor.name !== 'Socket'));
55-
check_called = true;
56-
}, 0);
55+
}), 0);
5756
}
58-
let check_called = false;
5957

6058
process.on('exit', function() {
6159
assert.strictEqual(rounds, ROUNDS);
6260
assert.strictEqual(reqs, ROUNDS * ATTEMPTS_PER_ROUND);
63-
assert(check_called);
6461
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.