Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bd2e521

Browse filesBrowse files
danbevMylesBorins
authored andcommitted
src: rename return var in VerifySpkac functions
This commit renames the verification result variable, that is currently named i, to verify_result. PR-URL: #20218 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent a4dae6c commit bd2e521
Copy full SHA for bd2e521

File tree

Expand file treeCollapse file tree

1 file changed

+7
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-7
lines changed
Open diff view settings
Collapse file

‎src/node_crypto.cc‎

Copy file name to clipboardExpand all lines: src/node_crypto.cc
+7-7Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5148,7 +5148,7 @@ void GetCurves(const FunctionCallbackInfo<Value>& args) {
51485148

51495149

51505150
bool VerifySpkac(const char* data, unsigned int len) {
5151-
bool i = false;
5151+
bool verify_result = false;
51525152
EVP_PKEY* pkey = nullptr;
51535153
NETSCAPE_SPKI* spki = nullptr;
51545154

@@ -5160,7 +5160,7 @@ bool VerifySpkac(const char* data, unsigned int len) {
51605160
if (pkey == nullptr)
51615161
goto exit;
51625162

5163-
i = NETSCAPE_SPKI_verify(spki, pkey) > 0;
5163+
verify_result = NETSCAPE_SPKI_verify(spki, pkey) > 0;
51645164

51655165
exit:
51665166
if (pkey != nullptr)
@@ -5169,23 +5169,23 @@ bool VerifySpkac(const char* data, unsigned int len) {
51695169
if (spki != nullptr)
51705170
NETSCAPE_SPKI_free(spki);
51715171

5172-
return i;
5172+
return verify_result;
51735173
}
51745174

51755175

51765176
void VerifySpkac(const FunctionCallbackInfo<Value>& args) {
5177-
bool i = false;
5177+
bool verify_result = false;
51785178

51795179
size_t length = Buffer::Length(args[0]);
51805180
if (length == 0)
5181-
return args.GetReturnValue().Set(i);
5181+
return args.GetReturnValue().Set(verify_result);
51825182

51835183
char* data = Buffer::Data(args[0]);
51845184
CHECK_NE(data, nullptr);
51855185

5186-
i = VerifySpkac(data, length);
5186+
verify_result = VerifySpkac(data, length);
51875187

5188-
args.GetReturnValue().Set(i);
5188+
args.GetReturnValue().Set(verify_result);
51895189
}
51905190

51915191

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.