Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bd13193

Browse filesBrowse files
BridgeARMylesBorins
authored andcommitted
lib: remove unnecessary require
The call to url was not necessary since the `url` module itself was already taking care of this. PR-URL: #20567 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
1 parent 0753774 commit bd13193
Copy full SHA for bd13193

File tree

Expand file treeCollapse file tree

2 files changed

+2
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-4
lines changed
Open diff view settings
Collapse file

‎lib/internal/bootstrap/node.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/node.js
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,6 @@
8989
setupGlobalURL();
9090
}
9191

92-
// Ensure setURLConstructor() is called before the native
93-
// URL::ToObject() method is used.
94-
NativeModule.require('internal/url');
95-
9692
// On OpenBSD process.execPath will be relative unless we
9793
// get the full path before process.execPath is used.
9894
if (process.platform === 'openbsd') {
Collapse file

‎lib/url.js‎

Copy file name to clipboardExpand all lines: lib/url.js
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ const {
3030
ERR_INVALID_ARG_TYPE
3131
} = require('internal/errors').codes;
3232

33+
// This ensures setURLConstructor() is called before the native
34+
// URL::ToObject() method is used.
3335
const { spliceOne } = require('internal/util');
3436

3537
// WHATWG URL implementation provided by internal/url

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.