Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit bcbcce5

Browse filesBrowse files
cclausstargos
cclauss
authored and
targos
committed
tools: undefined name opts -> args in gyptest.py
``` ./tools/gyp/gyptest.py:61:47: F821 undefined name 'opts' extra_path = [os.path.abspath(p) for p in opts.path] ^ ``` `opts.path` is an undefined name in this context while `args.path` is used on the preceding line and is defined on line 48. Undefined names have the potential to raise `NameError` at runtime which will halt the script. PR-URL: #30144 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 104bfb9 commit bcbcce5
Copy full SHA for bcbcce5

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎tools/gyp/gyptest.py‎

Copy file name to clipboardExpand all lines: tools/gyp/gyptest.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def main(argv=None):
5858
os.chdir(args.chdir)
5959

6060
if args.path:
61-
extra_path = [os.path.abspath(p) for p in opts.path]
61+
extra_path = [os.path.abspath(p) for p in args.path]
6262
extra_path = os.pathsep.join(extra_path)
6363
os.environ['PATH'] = extra_path + os.pathsep + os.environ['PATH']
6464

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.