Commit bcb255d
deps: V8: cherry-pick cb00db4dba6c
Original commit message:
[compiler] fix CompileFunction ignoring kEagerCompile
v8::ScriptCompiler::CompileFunction was ignoring kEagerCompile. Unlike
the other functions in v8::ScriptCompiler, it was not actually
propagating kEagerCompile to the parser. The newly updated test fails
without this change.
I did some archeology and found that this was commented out since the
original CL in https://crrev.com/c/980944.
As far as I know Node.js is the main consumer of this particular API.
This CL speeds up Node.js's overall startup time by ~13%.
Change-Id: Ifc3cd6653555194d46ca48db14f7ba7a4afe0053
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4571822
Commit-Queue: Marja Hölttä <marja@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/main@{#87944}
Refs: v8/v8@cb00db4
PR-URL: #48671
Refs: #48576
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>1 parent 3f65598 commit bcb255dCopy full SHA for bcb255d
File tree
Expand file treeCollapse file tree
2 files changed
+32
-1
lines changedOpen diff view settings
Filter options
- deps/v8
- src/codegen
- test/cctest
Expand file treeCollapse file tree
2 files changed
+32
-1
lines changedOpen diff view settings
Collapse file
deps/v8/src/codegen/compiler.cc
Copy file name to clipboardExpand all lines: deps/v8/src/codegen/compiler.cc+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
3199 | 3199 | |
3200 | 3200 | |
3201 | 3201 | |
3202 | | - |
| 3202 | + |
3203 | 3203 | |
3204 | 3204 | |
3205 | 3205 | |
|
Collapse file
deps/v8/test/cctest/test-serialize.cc
Copy file name to clipboardExpand all lines: deps/v8/test/cctest/test-serialize.cc+31Lines changed: 31 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
4937 | 4937 | |
4938 | 4938 | |
4939 | 4939 | |
| 4940 | + |
| 4941 | + |
| 4942 | + |
| 4943 | + |
| 4944 | + |
| 4945 | + |
| 4946 | + |
| 4947 | + |
| 4948 | + |
| 4949 | + |
| 4950 | + |
| 4951 | + |
| 4952 | + |
| 4953 | + |
| 4954 | + |
| 4955 | + |
| 4956 | + |
| 4957 | + |
| 4958 | + |
| 4959 | + |
| 4960 | + |
| 4961 | + |
| 4962 | + |
| 4963 | + |
| 4964 | + |
| 4965 | + |
| 4966 | + |
| 4967 | + |
| 4968 | + |
| 4969 | + |
| 4970 | + |
4940 | 4971 | |
4941 | 4972 | |
4942 | 4973 | |
|
0 commit comments