Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bc8f7db

Browse filesBrowse files
codebytereaduh95
authored andcommitted
test: correct conditional secure heap flags test
PR-URL: #60385 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 13120a4 commit bc8f7db
Copy full SHA for bc8f7db

File tree

Expand file treeCollapse file tree

1 file changed

+5
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-0
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-process-env-allowed-flags-are-documented.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-process-env-allowed-flags-are-documented.js
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ if (!hasOpenSSL3) {
4949
documented.delete('--openssl-shared-config');
5050
}
5151

52+
const isV8Sandboxed = process.config.variables.v8_enable_sandbox;
53+
5254
// Filter out options that are conditionally present.
5355
const conditionalOpts = [
5456
{
@@ -74,6 +76,9 @@ const conditionalOpts = [
7476
}, {
7577
include: process.features.inspector,
7678
filter: (opt) => opt.startsWith('--inspect') || opt === '--debug-port'
79+
}, {
80+
include: !isV8Sandboxed,
81+
filter: (opt) => ['--secure-heap', '--secure-heap-min'].includes(opt)
7782
},
7883
];
7984
documented.forEach((opt) => {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.