nodejs
diff --git a/Collapse file
‎lib/internal/test_runner/reporter/junit.js‎
Copy file name to clipboardExpand all lines: lib/internal/test_runner/reporter/junit.js
+1-1Lines changed: 1 addition & 1 deletion b/Collapse file
‎lib/internal/test_runner/reporter/junit.js‎
Copy file name to clipboardExpand all lines: lib/internal/test_runner/reporter/junit.js
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/Collapse file
‎test/parallel/test-runner-reporters.js‎
Copy file name to clipboardExpand all lines: test/parallel/test-runner-reporters.js
+13Lines changed: 13 additions & 0 deletions b/Collapse file
‎test/parallel/test-runner-reporters.js‎
Copy file name to clipboardExpand all lines: test/parallel/test-runner-reporters.js
+13Lines changed: 13 additions & 0 deletions
@@ -56,7 +56,7 @@ function isFailure(node) {
 }
 
 function isSkipped(node) {
-  return (node?.children && ArrayPrototypeSome(node.children, (c) => c.tag === 'skipped')) || node?.attrs?.failures;
+  return (node?.children && ArrayPrototypeSome(node.children, (c) => c.tag === 'skipped')) || node?.attrs?.skipped;
 }
 
 module.exports = async function* junitReporter(source) {
 
@@ -191,4 +191,17 @@ describe('node:test reporters', { concurrency: true }, () => {
     assert.match(fileConent, /ℹ skipped 0/);
     assert.match(fileConent, /ℹ todo 0/);
   });
+
+  it('should correctly report pass/fail for junit reporter using reporters.js', async () => {
+    const file = tmpdir.resolve(`${tmpFiles++}.xml`);
+    const child = spawnSync(process.execPath,
+                            ['--test', '--test-reporter', 'junit', '--test-reporter-destination', file, testFile]);
+    assert.strictEqual(child.stderr.toString(), '');
+    assert.strictEqual(child.stdout.toString(), '');
+    const fileContents = fs.readFileSync(file, 'utf8');
+    assert.match(fileContents, /<testsuite .*name="nested".*tests="2".*failures="1".*skipped="0".*>/);
+    assert.match(fileContents, /<testcase .*name="failing".*>\s*<failure .*type="testCodeFailure".*message="error".*>/);
+    assert.match(fileContents, /<testcase .*name="ok".*classname="test".*\/>/);
+    assert.match(fileContents, /<testcase .*name="top level".*classname="test".*\/>/);
+  });
 });
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ function isFailure(node) {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`function isSkipped(node) {`
`59`		`- return (node?.children && ArrayPrototypeSome(node.children, (c) => c.tag === 'skipped')) \|\| node?.attrs?.failures;`
	`59`	`+ return (node?.children && ArrayPrototypeSome(node.children, (c) => c.tag === 'skipped')) \|\| node?.attrs?.skipped;`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`module.exports = async function* junitReporter(source) {`