Commit bc19a93
test: use tmpDir in test-fs-utimes
test-fs-utimes was doing some tests against __filename. This made the
test unreliable when multiple copies were run simultaneously. In
general, tests should use files in either the tmp directory or else
fixtures, so change to using `common.tmpDir` instead. Each copy of the
test (if using `test.py` harness for parallel runs) will use its own
directory, making the test robust again.
PR-URL: #16774
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>1 parent 4c11801 commit bc19a93Copy full SHA for bc19a93
File tree
Expand file treeCollapse file tree
1 file changed
+9
-11
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+9
-11
lines changedOpen diff view settings
Collapse file
test/parallel/test-fs-utimes.js
Copy file name to clipboardExpand all lines: test/parallel/test-fs-utimes.js+9-11Lines changed: 9 additions & 11 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
25 | 25 | |
26 | 26 | |
27 | 27 | |
| 28 | + |
| 29 | + |
28 | 30 | |
29 | 31 | |
30 | 32 | |
| ||
64 | 66 | |
65 | 67 | |
66 | 68 | |
67 | | - |
68 | | - |
69 | | - |
70 | 69 | |
71 | 70 | |
72 | 71 | |
73 | 72 | |
74 | 73 | |
75 | 74 | |
76 | 75 | |
77 | | - |
78 | | - |
| 76 | + |
| 77 | + |
79 | 78 | |
80 | 79 | |
81 | 80 | |
| ||
110 | 109 | |
111 | 110 | |
112 | 111 | |
113 | | - |
114 | | - |
| 112 | + |
| 113 | + |
115 | 114 | |
116 | 115 | |
117 | 116 | |
118 | 117 | |
119 | 118 | |
120 | 119 | |
121 | | - |
| 120 | + |
122 | 121 | |
123 | | - |
| 122 | + |
124 | 123 | |
125 | 124 | |
126 | 125 | |
| ||
140 | 139 | |
141 | 140 | |
142 | 141 | |
143 | | - |
| 142 | + |
144 | 143 | |
145 | 144 | |
146 | 145 | |
| ||
169 | 168 | |
170 | 169 | |
171 | 170 | |
172 | | - |
173 | 171 | |
174 | 172 | |
175 | 173 | |
|
0 commit comments