Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bb780d2

Browse filesBrowse files
fedekauMylesBorins
authored andcommitted
test: use Countdown in http-agent test
PR-URL: #17537 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
1 parent dcb53c1 commit bb780d2
Copy full SHA for bb780d2

File tree

Expand file treeCollapse file tree

1 file changed

+7
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-3
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-http-agent.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-agent.js
+7-3Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
'use strict';
2323
const common = require('../common');
24+
const Countdown = require('../common/countdown');
2425
const assert = require('assert');
2526
const http = require('http');
2627
common.crashOnUnhandledRejection();
@@ -33,14 +34,17 @@ const server = http.Server(common.mustCall(function(req, res) {
3334
}, (N * M))); // N * M = good requests (the errors will not be counted)
3435

3536
function makeRequests(outCount, inCount, shouldFail) {
36-
let responseCount = outCount * inCount;
37+
const countdown = new Countdown(
38+
outCount * inCount,
39+
common.mustCall(() => server.close())
40+
);
3741
let onRequest = common.mustNotCall(); // Temporary
3842
const p = new Promise((resolve) => {
3943
onRequest = common.mustCall((res) => {
40-
if (--responseCount === 0) {
41-
server.close();
44+
if (countdown.dec() === 0) {
4245
resolve();
4346
}
47+
4448
if (!shouldFail)
4549
res.resume();
4650
}, outCount * inCount);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.