Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit bb729a4

Browse filesBrowse files
refacktargos
refack
authored and
targos
committed
deps: V8: fix BUILDING_V8_SHARED issues
Backport-PR-URL: #28005 PR-URL: #27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent f8a33ab commit bb729a4
Copy full SHA for bb729a4

File tree

Expand file treeCollapse file tree

5 files changed

+9
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

5 files changed

+9
-1
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.11',
41+
'v8_embedder_string': '-node.12',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/src/objects/ordered-hash-table.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/objects/ordered-hash-table.cc
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -930,6 +930,7 @@ OrderedHashTableHandler<SmallOrderedNameDictionary,
930930
OrderedNameDictionary>::Allocate(Isolate* isolate,
931931
int capacity);
932932

933+
#if !defined(V8_OS_WIN)
933934
template <class SmallTable, class LargeTable>
934935
bool OrderedHashTableHandler<SmallTable, LargeTable>::Delete(
935936
Handle<HeapObject> table, Handle<Object> key) {
@@ -942,7 +943,9 @@ bool OrderedHashTableHandler<SmallTable, LargeTable>::Delete(
942943
// down to a smaller hash table.
943944
return LargeTable::Delete(Handle<LargeTable>::cast(table), key);
944945
}
946+
#endif
945947

948+
#if !defined(V8_OS_WIN)
946949
template <class SmallTable, class LargeTable>
947950
bool OrderedHashTableHandler<SmallTable, LargeTable>::HasKey(
948951
Isolate* isolate, Handle<HeapObject> table, Handle<Object> key) {
@@ -953,6 +956,7 @@ bool OrderedHashTableHandler<SmallTable, LargeTable>::HasKey(
953956
DCHECK(LargeTable::Is(table));
954957
return LargeTable::HasKey(isolate, LargeTable::cast(*table), *key);
955958
}
959+
#endif
956960

957961
template bool
958962
OrderedHashTableHandler<SmallOrderedHashSet, OrderedHashSet>::HasKey(
Collapse file

‎deps/v8/src/setup-isolate-deserialize.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/setup-isolate-deserialize.cc
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include "src/interpreter/interpreter.h"
99
#include "src/isolate.h"
1010
#include "src/ostreams.h"
11+
#include "src/objects-inl.h"
1112

1213
namespace v8 {
1314
namespace internal {
Collapse file

‎deps/v8/src/snapshot/snapshot.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/snapshot/snapshot.h
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include "src/snapshot/partial-serializer.h"
99
#include "src/snapshot/startup-serializer.h"
1010

11+
#include "src/objects-inl.h"
1112
#include "src/utils.h"
1213

1314
namespace v8 {
Collapse file

‎deps/v8/src/vector.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/vector.h
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,7 @@ class EmbeddedVector : public Vector<T> {
321321
}
322322
}
323323

324+
#if !defined(V8_OS_WIN)
324325
// When copying, make underlying Vector to reference our buffer.
325326
EmbeddedVector(const EmbeddedVector& rhs) V8_NOEXCEPT : Vector<T>(rhs) {
326327
MemCopy(buffer_, rhs.buffer_, sizeof(T) * kSize);
@@ -334,6 +335,7 @@ class EmbeddedVector : public Vector<T> {
334335
this->set_start(buffer_);
335336
return *this;
336337
}
338+
#endif
337339

338340
private:
339341
T buffer_[kSize];

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.