Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit bb57e90

Browse filesBrowse files
richardlaumarco-ippolito
richardlau
authored and
marco-ippolito
committed
src: remove base64 from process.versions
The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: #52714 PR-URL: #53442 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent 561493d commit bb57e90
Copy full SHA for bb57e90

File tree

Expand file treeCollapse file tree

4 files changed

+1
-11
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

4 files changed

+1
-11
lines changed
Open diff view settings
Collapse file

‎src/base64_version.h‎

Copy file name to clipboardExpand all lines: src/base64_version.h
-6Lines changed: 0 additions & 6 deletions
This file was deleted.
Collapse file

‎src/node_metadata.cc‎

Copy file name to clipboardExpand all lines: src/node_metadata.cc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
#include "acorn_version.h"
33
#include "ada.h"
44
#include "ares.h"
5-
#include "base64_version.h"
65
#include "brotli/encode.h"
76
#include "cjs_module_lexer_version.h"
87
#include "llhttp.h"
@@ -121,7 +120,6 @@ Metadata::Versions::Versions() {
121120

122121
acorn = ACORN_VERSION;
123122
cjs_module_lexer = CJS_MODULE_LEXER_VERSION;
124-
base64 = BASE64_VERSION;
125123
uvwasi = UVWASI_VERSION_STRING;
126124

127125
#if HAVE_OPENSSL
Collapse file

‎src/node_metadata.h‎

Copy file name to clipboardExpand all lines: src/node_metadata.h
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,7 @@ namespace node {
4949
V(simdutf) \
5050
V(ada) \
5151
NODE_VERSIONS_KEY_UNDICI(V) \
52-
V(cjs_module_lexer) \
53-
V(base64)
52+
V(cjs_module_lexer)
5453

5554
#if HAVE_OPENSSL
5655
#define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl)
Collapse file

‎test/parallel/test-process-versions.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-process-versions.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ const expected_keys = [
2121
'simdutf',
2222
'ada',
2323
'cjs_module_lexer',
24-
'base64',
2524
];
2625

2726
const hasUndici = process.config.variables.node_builtin_shareable_builtins.includes('deps/undici/undici.js');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.