Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bb10819

Browse filesBrowse files
avivkellermarco-ippolito
authored andcommitted
meta: call create-release-post.yml post release
PR-URL: #60366 Refs: nodejs/nodejs.org#8231 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent a07a277 commit bb10819
Copy full SHA for bb10819

File tree

Expand file treeCollapse file tree

3 files changed

+53
-51
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+53
-51
lines changed
Open diff view settings
Collapse file

‎.github/workflows/post-release.yml‎

Copy file name to clipboard
+32Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
name: Post-Release actions
2+
3+
on:
4+
workflow_dispatch:
5+
inputs:
6+
version:
7+
description: The version to generate a blog post for.
8+
type: string
9+
required: true
10+
release:
11+
types: [released]
12+
13+
permissions:
14+
contents: read
15+
16+
jobs:
17+
post-release-actions:
18+
if: github.repository == 'nodejs/node'
19+
runs-on: ubuntu-latest
20+
steps:
21+
- name: Trigger update-links workflow on nodejs/release-cloudflare-worker
22+
run: |
23+
gh workflow run update-links.yml --repo nodejs/release-cloudflare-worker
24+
env:
25+
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
26+
27+
- name: Trigger create-release-post workflow on nodejs/nodejs.org
28+
run: |
29+
gh workflow run create-release-post.yml --repo nodejs/nodejs.org -f version=$VERSION
30+
env:
31+
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
32+
VERSION: ${{ inputs.version || github.event.release.tag_name }}
Collapse file

‎.github/workflows/update-release-links.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/update-release-links.yml
-20Lines changed: 0 additions & 20 deletions
This file was deleted.
Collapse file

‎doc/contributing/releases.md‎

Copy file name to clipboardExpand all lines: doc/contributing/releases.md
+21-31Lines changed: 21 additions & 31 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ official release builds for Node.js, hosted on <https://nodejs.org/>.
3030
* [14. Push the release tag](#14-push-the-release-tag)
3131
* [15. Promote and sign the release builds](#15-promote-and-sign-the-release-builds)
3232
* [16. Check the release](#16-check-the-release)
33-
* [17. Create a blog post](#17-create-a-blog-post)
34-
* [18. Create the release on GitHub](#18-create-the-release-on-github)
33+
* [17. Create the release on GitHub](#17-create-the-release-on-github)
34+
* [18. Create a blog post](#18-create-a-blog-post)
3535
* [19. Announce](#19-announce)
3636
* [20. Celebrate](#20-celebrate)
3737
* [LTS releases](#lts-releases)
@@ -1047,21 +1047,31 @@ have the right internal version strings. Check that the API docs are available
10471047
at <https://nodejs.org/api/>. Check that the release catalog files are correct
10481048
at <https://nodejs.org/dist/index.tab> and <https://nodejs.org/dist/index.json>.
10491049

1050-
### 17. Create a blog post
1050+
### 17. Create the release on GitHub
1051+
1052+
* Go to the [New release page](https://github.com/nodejs/node/releases/new).
1053+
* Select the tag version you pushed earlier.
1054+
* For release title, copy the title from the changelog.
1055+
* For the description, copy the rest of the changelog entry.
1056+
* If you are not releasing the latest "Current", uncheck
1057+
"Set as the latest release".
1058+
* Click on the "Publish release" button.
1059+
1060+
### 18. Create a blog post
10511061

10521062
There is an automatic build that is kicked off when you promote new builds, so
10531063
within a few minutes nodejs.org will be listing your new version as the latest
1054-
release. However, the blog post is not yet fully automatic.
1064+
release, and a blog post draft PR will be created.
10551065

1056-
Create a new blog post by running the [nodejs.org release-post.js script][]:
1066+
In the event that a draft PR _is not created_, the [`scripts:release-post`][] script
1067+
can be used as an alternative:
10571068

10581069
```bash
1059-
node ./apps/site/scripts/release-post/index.mjs x.y.z
1070+
# In the apps/site folder of nodejs/nodejs.org
1071+
node --run scripts:release-post x.y.z
10601072
```
10611073

1062-
This script will use the promoted builds and changelog to generate the post. Run
1063-
`npm run serve` to preview the post locally before pushing to the
1064-
[nodejs.org repository][].
1074+
This script will use the promoted builds and changelog to generate the post.
10651075

10661076
* You can add a short blurb just under the main heading if you want to say
10671077
something important, otherwise the text should be publication ready.
@@ -1076,33 +1086,13 @@ This script will use the promoted builds and changelog to generate the post. Run
10761086
to reflect those changes.
10771087

10781088
* Always use pull-requests on the [nodejs.org repository][]. Be respectful
1079-
of the website team, but you do not have to wait for PR sign-off. Please
1080-
use the following commit message format:
1081-
1082-
```console
1083-
Blog: vX.Y.Z release post
1084-
1085-
Refs: <full URL to your release proposal PR>
1086-
```
1087-
1088-
* In order to trigger the CI Checks of the [nodejs.org repository][]; Please
1089-
attach the `github_actions:pull-request` label to the PR.
1089+
of the website team, but you do not have to wait for PR sign-off.
10901090

10911091
* Changes to the base branch, `main`, on the [nodejs.org repository][] will
10921092
trigger a new build of nodejs.org, so your changes should appear a few minutes
10931093
after pushing. You can follow the [Deployments](https://github.com/nodejs/nodejs.org/deployments) page
10941094
to see when the build finishes and gets published.
10951095

1096-
### 18. Create the release on GitHub
1097-
1098-
* Go to the [New release page](https://github.com/nodejs/node/releases/new).
1099-
* Select the tag version you pushed earlier.
1100-
* For release title, copy the title from the changelog.
1101-
* For the description, copy the rest of the changelog entry.
1102-
* If you are not releasing the latest "Current", uncheck
1103-
"Set as the latest release".
1104-
* Click on the "Publish release" button.
1105-
11061096
### 19. Announce
11071097

11081098
The nodejs.org website will automatically rebuild and include the new version.
@@ -1469,7 +1459,7 @@ Typical resolution: sign the release again.
14691459
[Node.js Snap management repository]: https://github.com/nodejs/snap
14701460
[Snap]: https://snapcraft.io/node
14711461
[`create-release-proposal`]: https://github.com/nodejs/node/actions/workflows/create-release-proposal.yml
1462+
[`scripts:release-post`]: https://github.com/nodejs/nodejs.org/blob/HEAD/apps/site/scripts/release-post/index.mjs
14721463
[build-infra team]: https://github.com/orgs/nodejs/teams/build-infra
14731464
[expected assets]: https://github.com/nodejs/build/tree/HEAD/ansible/www-standalone/tools/promote/expected_assets
1474-
[nodejs.org release-post.js script]: https://github.com/nodejs/nodejs.org/blob/HEAD/apps/site/scripts/release-post/index.mjs
14751465
[nodejs.org repository]: https://github.com/nodejs/nodejs.org

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.