Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bab9c4d

Browse filesBrowse files
KhafraDevtargos
authored andcommitted
events: getMaxListeners detects 0 listeners
PR-URL: #56807 Refs: nodejs/undici#4032 Refs: c1ccade Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
1 parent 3af23a1 commit bab9c4d
Copy full SHA for bab9c4d

File tree

Expand file treeCollapse file tree

2 files changed

+6
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+6
-1
lines changed
Open diff view settings
Collapse file

‎lib/events.js‎

Copy file name to clipboardExpand all lines: lib/events.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -939,7 +939,7 @@ function getEventListeners(emitterOrTarget, type) {
939939
function getMaxListeners(emitterOrTarget) {
940940
if (typeof emitterOrTarget?.getMaxListeners === 'function') {
941941
return _getMaxListeners(emitterOrTarget);
942-
} else if (emitterOrTarget?.[kMaxEventTargetListeners]) {
942+
} else if (typeof emitterOrTarget?.[kMaxEventTargetListeners] === 'number') {
943943
return emitterOrTarget[kMaxEventTargetListeners];
944944
}
945945

Collapse file

‎test/parallel/test-events-getmaxlisteners.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-events-getmaxlisteners.js
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,8 @@ const { getMaxListeners, EventEmitter, defaultMaxListeners, setMaxListeners } =
1717
setMaxListeners(101, et);
1818
assert.strictEqual(getMaxListeners(et), 101);
1919
}
20+
21+
{
22+
const ac = new AbortController();
23+
assert.strictEqual(getMaxListeners(ac.signal), 0);
24+
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.