Commit ba444a9
vm: implement isContext() directly in JS land with private symbol
We are now directly checking the existence of a private symbol
in the object to determine if an object is a ContextifyContext
anyway, so there is no need to implement it in C++ anymore.
PR-URL: #51685
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent d7563a5 commit ba444a9Copy full SHA for ba444a9
File tree
Expand file treeCollapse file tree
4 files changed
+22
-24
lines changedOpen diff view settings
Filter options
- lib
- internal
- vm
- src
Expand file treeCollapse file tree
4 files changed
+22
-24
lines changedOpen diff view settings
Collapse file
+6-6Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
8 | 8 | |
9 | 9 | |
10 | 10 | |
11 | | - |
12 | 11 | |
13 | 12 | |
14 | 13 | |
| ||
21 | 20 | |
22 | 21 | |
23 | 22 | |
24 | | - |
25 | | - |
26 | 23 | |
27 | 24 | |
28 | 25 | |
29 | 26 | |
30 | 27 | |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
31 | 33 | |
32 | 34 | |
33 | | - |
34 | | - |
35 | | - |
| 35 | + |
36 | 36 | |
37 | 37 | |
38 | 38 | |
|
Collapse file
+2-1Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
17 | 17 | |
18 | 18 | |
19 | 19 | |
20 | | - |
21 | 20 | |
22 | 21 | |
23 | 22 | |
| ||
75 | 74 | |
76 | 75 | |
77 | 76 | |
| 77 | + |
| 78 | + |
78 | 79 | |
79 | 80 | |
80 | 81 | |
|
Collapse file
+14-1Lines changed: 14 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
49 | 49 | |
50 | 50 | |
51 | 51 | |
| 52 | + |
52 | 53 | |
53 | 54 | |
54 | 55 | |
| ||
59 | 60 | |
60 | 61 | |
61 | 62 | |
62 | | - |
| 63 | + |
63 | 64 | |
64 | 65 | |
65 | 66 | |
66 | 67 | |
67 | 68 | |
68 | 69 | |
69 | 70 | |
| 71 | + |
| 72 | + |
| 73 | + |
| 74 | + |
| 75 | + |
| 76 | + |
| 77 | + |
| 78 | + |
| 79 | + |
| 80 | + |
| 81 | + |
| 82 | + |
70 | 83 | |
71 | 84 | |
72 | 85 | |
|
Collapse file
-16Lines changed: 0 additions & 16 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
342 | 342 | |
343 | 343 | |
344 | 344 | |
345 | | - |
346 | 345 | |
347 | 346 | |
348 | 347 | |
349 | 348 | |
350 | 349 | |
351 | 350 | |
352 | 351 | |
353 | | - |
354 | 352 | |
355 | 353 | |
356 | 354 | |
| ||
415 | 413 | |
416 | 414 | |
417 | 415 | |
418 | | - |
419 | | - |
420 | | - |
421 | | - |
422 | | - |
423 | | - |
424 | | - |
425 | | - |
426 | | - |
427 | | - |
428 | | - |
429 | | - |
430 | | - |
431 | | - |
432 | 416 | |
433 | 417 | |
434 | 418 | |
|
0 commit comments