Commit b93c8a7
test: fix flaky doctool and test
Doctool tests have been failing a lot in CI on Win2008 R2. It appears
async functions and callback-based functions are being used in
combination such that the callback-based function cannot guarantee that
it will invoke its callback. Convert the callback-based functions to
async functions so we have one paradigm and reliable results.
PR-URL: #29979
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>1 parent a23b5cb commit b93c8a7Copy full SHA for b93c8a7
File tree
Expand file treeCollapse file tree
3 files changed
+19
-34
lines changedOpen diff view settings
Filter options
- test/doctool
- tools/doc
Expand file treeCollapse file tree
3 files changed
+19
-34
lines changedOpen diff view settings
Collapse file
test/doctool/test-doctool-html.js
Copy file name to clipboardExpand all lines: test/doctool/test-doctool-html.js+11-21Lines changed: 11 additions & 21 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
22 | 22 | |
23 | 23 | |
24 | 24 | |
25 | | - |
| 25 | + |
26 | 26 | |
27 | 27 | |
28 | 28 | |
| ||
34 | 34 | |
35 | 35 | |
36 | 36 | |
37 | | - |
38 | | - |
39 | | - |
40 | | - |
| 37 | + |
41 | 38 | |
42 | 39 | |
43 | 40 | |
| ||
107 | 104 | |
108 | 105 | |
109 | 106 | |
110 | | - |
| 107 | + |
111 | 108 | |
112 | | - |
113 | | - |
114 | | - |
115 | | - |
116 | | - |
117 | | - |
118 | | - |
119 | | - |
| 109 | + |
| 110 | + |
| 111 | + |
120 | 112 | |
121 | | - |
122 | | - |
123 | | - |
124 | | - |
125 | | - |
126 | | - |
127 | | - |
| 113 | + |
| 114 | + |
| 115 | + |
| 116 | + |
| 117 | + |
128 | 118 | |
129 | 119 | |
Collapse file
+6-11Lines changed: 6 additions & 11 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
67 | 67 | |
68 | 68 | |
69 | 69 | |
70 | | - |
| 70 | + |
71 | 71 | |
72 | 72 | |
73 | 73 | |
| ||
84 | 84 | |
85 | 85 | |
86 | 86 | |
87 | | - |
88 | | - |
89 | | - |
90 | | - |
91 | | - |
92 | | - |
93 | | - |
94 | | - |
| 87 | + |
| 88 | + |
| 89 | + |
95 | 90 | |
96 | | - |
97 | | - |
| 91 | + |
| 92 | + |
98 | 93 | |
Collapse file
+2-2Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
63 | 63 | |
64 | 64 | |
65 | 65 | |
66 | | - |
| 66 | + |
67 | 67 | |
68 | 68 | |
69 | 69 | |
| ||
87 | 87 | |
88 | 88 | |
89 | 89 | |
90 | | - |
| 90 | + |
91 | 91 | |
92 | 92 | |
93 | 93 | |
|
0 commit comments