Commit b929988
dns: use isIp consistently
Currently the DNS module imports isIP from both cares and `net` and
uses both of them both throughout the code base. This PR removes the
direct dependency `dns` has on `net` and uses `isIp` from c-ares all
the time. Note that both functions do the same thing.
PR-URL: #5804
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent ccb7b45 commit b929988Copy full SHA for b929988
File tree
Expand file treeCollapse file tree
1 file changed
+6
-7
lines changedOpen diff view settings
Filter options
- lib
Expand file treeCollapse file tree
1 file changed
+6
-7
lines changedOpen diff view settings
Collapse file
+6-7Lines changed: 6 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | | - |
4 | 3 | |
5 | 4 | |
6 | 5 | |
| ||
11 | 10 | |
12 | 11 | |
13 | 12 | |
14 | | - |
| 13 | + |
15 | 14 | |
16 | 15 | |
17 | 16 | |
| ||
148 | 147 | |
149 | 148 | |
150 | 149 | |
151 | | - |
| 150 | + |
152 | 151 | |
153 | 152 | |
154 | 153 | |
| ||
188 | 187 | |
189 | 188 | |
190 | 189 | |
191 | | - |
| 190 | + |
192 | 191 | |
193 | 192 | |
194 | 193 | |
| ||
290 | 289 | |
291 | 290 | |
292 | 291 | |
293 | | - |
| 292 | + |
294 | 293 | |
295 | 294 | |
296 | 295 | |
| ||
299 | 298 | |
300 | 299 | |
301 | 300 | |
302 | | - |
| 301 | + |
303 | 302 | |
304 | 303 | |
305 | 304 | |
306 | 305 | |
307 | 306 | |
308 | | - |
| 307 | + |
309 | 308 | |
310 | 309 | |
311 | 310 | |
|
0 commit comments