Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit b833a59

Browse filesBrowse files
danbevMylesBorins
danbev
authored and
MylesBorins
committed
n-api: use nullptr instead of NULL in node_api.cc
This commit changes two checks which use NULL to use nullptr. I'm not very familiar with N-API but wanted to bring this up in case it was something that was overlooked. PR-URL: #17276 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: MichaëZasso <targos@protonmail.com>
1 parent e45c9c6 commit b833a59
Copy full SHA for b833a59

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎src/node_api.cc‎

Copy file name to clipboardExpand all lines: src/node_api.cc
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1220,7 +1220,7 @@ napi_status napi_delete_property(napi_env env,
12201220
v8::Maybe<bool> delete_maybe = obj->Delete(context, k);
12211221
CHECK_MAYBE_NOTHING(env, delete_maybe, napi_generic_failure);
12221222

1223-
if (result != NULL)
1223+
if (result != nullptr)
12241224
*result = delete_maybe.FromMaybe(false);
12251225

12261226
return GET_RETURN_STATUS(env);
@@ -1398,7 +1398,7 @@ napi_status napi_delete_element(napi_env env,
13981398
v8::Maybe<bool> delete_maybe = obj->Delete(context, index);
13991399
CHECK_MAYBE_NOTHING(env, delete_maybe, napi_generic_failure);
14001400

1401-
if (result != NULL)
1401+
if (result != nullptr)
14021402
*result = delete_maybe.FromMaybe(false);
14031403

14041404
return GET_RETURN_STATUS(env);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.