Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b8213f1

Browse filesBrowse files
Trotttargos
authored andcommitted
doc: remove linking of url text to url
Linking URL text to itself is superfluous. It will display as a link in GitHub anyway. Bonus: This makes it possible to wrap the line at 80 characters. PR-URL: #21361 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 3f78220 commit b8213f1
Copy full SHA for b8213f1

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎doc/onboarding.md‎

Copy file name to clipboardExpand all lines: doc/onboarding.md
+1-2Lines changed: 1 addition & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ needs to be pointed out separately during the onboarding.
206206
## Exercise: Make a PR adding yourself to the README
207207

208208
* Example:
209-
[https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0][]
209+
https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0
210210
* For raw commit message: `git log ce986de829457c39257cd205067602e765768fb0
211211
-1`
212212
* Collaborators are in alphabetical order by GitHub username.
@@ -250,7 +250,6 @@ needs to be pointed out separately during the onboarding.
250250
[`git-node`]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md
251251
[`node-core-utils`]: https://github.com/nodejs/node-core-utils
252252
[Landing Pull Requests]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests
253-
[https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0]: https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0
254253
[Publicizing or hiding organization membership]: https://help.github.com/articles/publicizing-or-hiding-organization-membership/
255254
[set up the credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials
256255
[two-factor authentication]: https://help.github.com/articles/securing-your-account-with-two-factor-authentication-2fa/

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.