Commit b7aa5e2
stream: remove isPromise utility function
The function was not checking if the parameter was actually a Promise
instance, but if it has a `then` method. Removing the utility function
in favor of a clearer `typeof` check, handling the case when the
thenable throws if then method is accessed more than once.
PR-URL: #35925
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 28ed7d0 commit b7aa5e2Copy full SHA for b7aa5e2
File tree
Expand file treeCollapse file tree
2 files changed
+32
-9
lines changedOpen diff view settings
Filter options
- lib/internal/streams
- test/parallel
Expand file treeCollapse file tree
2 files changed
+32
-9
lines changedOpen diff view settings
Collapse file
lib/internal/streams/pipeline.js
Copy file name to clipboardExpand all lines: lib/internal/streams/pipeline.js+11-9Lines changed: 11 additions & 9 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
5 | 5 | |
6 | 6 | |
7 | 7 | |
| 8 | + |
8 | 9 | |
9 | | - |
| 10 | + |
10 | 11 | |
11 | 12 | |
12 | 13 | |
| ||
77 | 78 | |
78 | 79 | |
79 | 80 | |
80 | | - |
81 | | - |
82 | | - |
83 | | - |
84 | 81 | |
85 | 82 | |
86 | 83 | |
| ||
222 | 219 | |
223 | 220 | |
224 | 221 | |
225 | | - |
226 | | - |
227 | | - |
| 222 | + |
| 223 | + |
| 224 | + |
| 225 | + |
| 226 | + |
| 227 | + |
| 228 | + |
228 | 229 | |
229 | 230 | |
230 | 231 | |
231 | 232 | |
232 | | - |
| 233 | + |
| 234 | + |
233 | 235 | |
234 | 236 | |
235 | 237 | |
|
Collapse file
test/parallel/test-stream-pipeline.js
Copy file name to clipboardExpand all lines: test/parallel/test-stream-pipeline.js+21Lines changed: 21 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1240 | 1240 | |
1241 | 1241 | |
1242 | 1242 | |
| 1243 | + |
| 1244 | + |
| 1245 | + |
| 1246 | + |
| 1247 | + |
| 1248 | + |
| 1249 | + |
| 1250 | + |
| 1251 | + |
| 1252 | + |
| 1253 | + |
| 1254 | + |
| 1255 | + |
| 1256 | + |
| 1257 | + |
| 1258 | + |
| 1259 | + |
| 1260 | + |
| 1261 | + |
| 1262 | + |
| 1263 | + |
0 commit comments