Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit b717956

Browse filesBrowse files
Trottjasnell
Trott
authored and
jasnell
committed
test: load common.js in all tests
common.js contains code that detects leaked variables. In preparation for an eslint rule that will enforce loading common.js in test files, load it everywhere it can be loaded and use an `eslint-disable` comment for files that intentionally leak. PR-URL: #3157 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 5d9f83f commit b717956
Copy full SHA for b717956

File tree

Expand file treeCollapse file tree

10 files changed

+11
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

10 files changed

+11
-0
lines changed
Open diff view settings
Collapse file

‎test/addons/async-hello-world/test.js‎

Copy file name to clipboardExpand all lines: test/addons/async-hello-world/test.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../../common');
23
var assert = require('assert');
34
var binding = require('./build/Release/binding');
45
var called = false;
Collapse file

‎test/addons/at-exit/test.js‎

Copy file name to clipboard
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
'use strict';
2+
require('../../common');
23
var binding = require('./build/Release/binding');
Collapse file

‎test/addons/heap-profiler/test.js‎

Copy file name to clipboardExpand all lines: test/addons/heap-profiler/test.js
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
'use strict';
22

3+
require('../../common');
4+
35
const binding = require('./build/Release/binding');
46

57
// Create an AsyncWrap object.
Collapse file

‎test/addons/hello-world-function-export/test.js‎

Copy file name to clipboardExpand all lines: test/addons/hello-world-function-export/test.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../../common');
23
var assert = require('assert');
34
var binding = require('./build/Release/binding');
45
assert.equal('world', binding());
Collapse file

‎test/addons/hello-world/test.js‎

Copy file name to clipboardExpand all lines: test/addons/hello-world/test.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../../common');
23
var assert = require('assert');
34
var binding = require('./build/Release/binding');
45
assert.equal('world', binding.hello());
Collapse file

‎test/addons/repl-domain-abort/test.js‎

Copy file name to clipboardExpand all lines: test/addons/repl-domain-abort/test.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../../common');
23
var assert = require('assert');
34
var repl = require('repl');
45
var stream = require('stream');
Collapse file

‎test/debugger/test-debugger-repl-break-in-module.js‎

Copy file name to clipboardExpand all lines: test/debugger/test-debugger-repl-break-in-module.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var repl = require('./helper-debugger-repl.js');
34

45
repl.startDebugger('break-in-module/main.js');
Collapse file

‎test/debugger/test-debugger-repl-restart.js‎

Copy file name to clipboardExpand all lines: test/debugger/test-debugger-repl-restart.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var repl = require('./helper-debugger-repl.js');
34

45
repl.startDebugger('breakpoints.js');
Collapse file

‎test/debugger/test-debugger-repl-term.js‎

Copy file name to clipboardExpand all lines: test/debugger/test-debugger-repl-term.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
process.env.NODE_FORCE_READLINE = 1;
34

45
var repl = require('./helper-debugger-repl.js');
Collapse file

‎test/debugger/test-debugger-repl.js‎

Copy file name to clipboardExpand all lines: test/debugger/test-debugger-repl.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
'use strict';
2+
require('../common');
23
var repl = require('./helper-debugger-repl.js');
34

45
repl.startDebugger('breakpoints.js');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.