Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit b61ae7f

Browse filesBrowse files
TrottMylesBorins
Trott
authored and
MylesBorins
committed
doc: remove "has been known" tentativeness
Remove unnecessary "has been known to" tentativeness from COLLABORATOR_GUIDE.md. "has been known to" is an awkward replacement for "can" or "might" or "sometimes does" or "does". Pick the right one and use it. PR-URL: #20412 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent dfcf20f commit b61ae7f
Copy full SHA for b61ae7f

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎COLLABORATOR_GUIDE.md‎

Copy file name to clipboardExpand all lines: COLLABORATOR_GUIDE.md
+1-2Lines changed: 1 addition & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -489,8 +489,7 @@ The TSC should serve as the final arbiter where required.
489489
1. Never use GitHub's green ["Merge Pull Request"][] button. Reasons for not
490490
using the web interface button:
491491
* The merge method will add an unnecessary merge commit.
492-
* The squash & merge method has been known to add metadata to the commit
493-
title (the PR #).
492+
* The squash & merge method can add metadata (the PR #) to the commit title.
494493
* If more than one author has contributed to the PR, keep the most recent
495494
author when squashing.
496495
1. Make sure the CI is done and the result is green. If the CI is not green,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.