Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit b606d46

Browse filesBrowse files
legendecasaduh95
legendecas
authored and
aduh95
committed
src: remove unconditional NAPI_EXPERIMENTAL in node.h
PR-URL: #60345 Fixes: #60311 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
1 parent 39dfcba commit b606d46
Copy full SHA for b606d46

File tree

Expand file treeCollapse file tree

6 files changed

+9
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

6 files changed

+9
-2
lines changed
Open diff view settings
Collapse file

‎node.gyp‎

Copy file name to clipboardExpand all lines: node.gyp
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -890,6 +890,9 @@
890890
'NODE_ARCH="<(target_arch)"',
891891
'NODE_PLATFORM="<(OS)"',
892892
'NODE_WANT_INTERNALS=1',
893+
# Define NAPI_EXPERIMENTAL to enable Node-API experimental function symbols being exposed.
894+
'NAPI_EXPERIMENTAL=1',
895+
'NODE_API_EXPERIMENTAL_NO_WARNING=1',
893896
# Warn when using deprecated V8 APIs.
894897
'V8_DEPRECATION_WARNINGS=1',
895898
'NODE_OPENSSL_SYSTEM_CERT_PATH="<(openssl_system_ca_path)"',
Collapse file

‎src/js_native_api_v8.cc‎

Copy file name to clipboardExpand all lines: src/js_native_api_v8.cc
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
#include <algorithm>
22
#include <climits> // INT_MAX
33
#include <cmath>
4+
#ifndef NAPI_EXPERIMENTAL
45
#define NAPI_EXPERIMENTAL
6+
#endif
57
#include "env-inl.h"
68
#include "js_native_api.h"
79
#include "js_native_api_v8.h"
Collapse file

‎src/node.h‎

Copy file name to clipboardExpand all lines: src/node.h
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@
7676
#include "v8-platform.h" // NOLINT(build/include_order)
7777
#include "node_version.h" // NODE_MODULE_VERSION
7878

79-
#define NAPI_EXPERIMENTAL
8079
#include "node_api.h"
8180

8281
#include <functional>
Collapse file

‎src/node_api.cc‎

Copy file name to clipboardExpand all lines: src/node_api.cc
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
#include "async_context_frame.h"
22
#include "async_wrap-inl.h"
33
#include "env-inl.h"
4+
#ifndef NAPI_EXPERIMENTAL
45
#define NAPI_EXPERIMENTAL
6+
#endif
57
#include "js_native_api_v8.h"
68
#include "memory_tracker-inl.h"
79
#include "node_api.h"
Collapse file

‎src/node_api_internals.h‎

Copy file name to clipboardExpand all lines: src/node_api_internals.h
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22
#define SRC_NODE_API_INTERNALS_H_
33

44
#include "v8.h"
5+
#ifndef NAPI_EXPERIMENTAL
56
#define NAPI_EXPERIMENTAL
7+
#endif
68
#include "env-inl.h"
79
#include "js_native_api_v8.h"
810
#include "node_api.h"
Collapse file

‎src/node_binding.h‎

Copy file name to clipboardExpand all lines: src/node_binding.h
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#endif
99

1010
#include "node.h"
11-
#define NAPI_EXPERIMENTAL
1211
#include "node_api.h"
1312
#include "quic/guard.h"
1413
#include "uv.h"

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.