Commit b5ca5ad
src: simplify
Just a little piece of cleanup -- this aligns `TCPWrap::Connect`
with its sibling `TCPWrap::Bind`, deduplicates code and removes
an unnecessary heap allocation.
Signed-off-by: Anna Henningsen <anna@addaleax.net>
PR-URL: #62929
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>TCPWrap::Connect signature1 parent ca02af1 commit b5ca5adCopy full SHA for b5ca5ad
2 files changed
+23-27Lines changed: 23 additions & 27 deletions
File tree
Expand file treeCollapse file tree
Open diff view settings
Filter options
- src
Expand file treeCollapse file tree
Open diff view settings
Collapse file
+15-22Lines changed: 15 additions & 22 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
372 | 372 | |
373 | 373 | |
374 | 374 | |
375 | | - |
376 | | - |
377 | | - |
378 | | - |
| 375 | + |
| 376 | + |
| 377 | + |
| 378 | + |
| 379 | + |
379 | 380 | |
380 | 381 | |
381 | 382 | |
| ||
424 | 425 | |
425 | 426 | |
426 | 427 | |
427 | | - |
428 | | - |
429 | | - |
430 | | - |
431 | | - |
432 | | - |
| 428 | + |
433 | 429 | |
434 | 430 | |
435 | 431 | |
436 | | - |
437 | | - |
438 | | - |
439 | | - |
440 | | - |
441 | | - |
442 | | - |
443 | | - |
| 432 | + |
444 | 433 | |
445 | 434 | |
446 | 435 | |
447 | | - |
448 | | - |
449 | | - |
| 436 | + |
| 437 | + |
| 438 | + |
| 439 | + |
450 | 440 | |
451 | 441 | |
452 | 442 | |
| ||
456 | 446 | |
457 | 447 | |
458 | 448 | |
| 449 | + |
| 450 | + |
| 451 | + |
459 | 452 | |
460 | 453 | |
461 | 454 | |
462 | 455 | |
463 | | - |
| 456 | + |
464 | 457 | |
465 | 458 | |
466 | 459 | |
|
Collapse file
+8-5Lines changed: 8 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
83 | 83 | |
84 | 84 | |
85 | 85 | |
86 | | - |
| 86 | + |
| 87 | + |
| 88 | + |
87 | 89 | |
88 | 90 | |
89 | | - |
90 | | - |
91 | | - |
92 | | - |
| 91 | + |
| 92 | + |
| 93 | + |
| 94 | + |
| 95 | + |
93 | 96 | |
94 | 97 | |
95 | 98 | |
|
0 commit comments