Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b55fba2

Browse filesBrowse files
addaleaxMylesBorins
authored andcommitted
fs: add missing HandleScope to FileHandle.close
Fixes: #31202 PR-URL: #31276 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 1df7961 commit b55fba2
Copy full SHA for b55fba2

File tree

Expand file treeCollapse file tree

2 files changed

+18
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+18
-0
lines changed
Open diff view settings
Collapse file

‎src/node_file.cc‎

Copy file name to clipboardExpand all lines: src/node_file.cc
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,7 @@ MaybeLocal<Promise> FileHandle::ClosePromise() {
301301
close->file_handle()->AfterClose();
302302
Isolate* isolate = close->env()->isolate();
303303
if (req->result < 0) {
304+
HandleScope handle_scope(isolate);
304305
close->Reject(UVException(isolate, req->result, "close"));
305306
} else {
306307
close->Resolve();
Collapse file
+17Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
'use strict';
2+
const common = require('../common');
3+
const assert = require('assert');
4+
const fs = require('fs');
5+
6+
// Test that using FileHandle.close to close an already-closed fd fails
7+
// with EBADF.
8+
9+
(async function() {
10+
const fh = await fs.promises.open(__filename);
11+
fs.closeSync(fh.fd);
12+
13+
assert.rejects(() => fh.close(), {
14+
code: 'EBADF',
15+
syscall: 'close'
16+
});
17+
})().then(common.mustCall());

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.