Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b502be1

Browse filesBrowse files
RafaelGSSmarco-ippolito
authored andcommitted
tools: disable automated libuv updates
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent f845a16 commit b502be1
Copy full SHA for b502be1

File tree

Expand file treeCollapse file tree

1 file changed

+12
-9
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+12
-9
lines changed
Open diff view settings
Collapse file

‎.github/workflows/tools.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/tools.yml
+12-9Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ on:
2727
- googletest
2828
- histogram
2929
- icu
30-
- libuv
30+
# - libuv
3131
- lint-md-dependencies
3232
- llhttp
3333
- minimatch
@@ -174,14 +174,17 @@ jobs:
174174
cat temp-output
175175
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
176176
rm temp-output
177-
- id: libuv
178-
subsystem: deps
179-
label: dependencies
180-
run: |
181-
./tools/dep_updaters/update-libuv.sh > temp-output
182-
cat temp-output
183-
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
184-
rm temp-output
177+
# libuv update was disabled because of Feb 14, 2024 security releas
178+
# modified the bundled version of libuv, we cannot automatically update
179+
# libuv without potentially undoing those changes.
180+
# - id: libuv
181+
# subsystem: deps
182+
# label: dependencies
183+
# run: |
184+
# ./tools/dep_updaters/update-libuv.sh > temp-output
185+
# cat temp-output
186+
# tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
187+
# rm temp-output
185188
- id: lint-md-dependencies
186189
subsystem: tools
187190
label: tools

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.