Commit b4510f7
test: refactor stream-*-constructor-set-methods
- Use `common.mustCall()` to ensure that callbacks are called.
- Remove no longer needed variables.
- Remove unnecessary `process.on('exit')` usage.
PR-URL: #18817
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent f18c801 commit b4510f7Copy full SHA for b4510f7
File tree
Expand file treeCollapse file tree
2 files changed
+35
-45
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
2 files changed
+35
-45
lines changedOpen diff view settings
Collapse file
test/parallel/test-stream-transform-constructor-set-methods.js
Copy file name to clipboard+13-15Lines changed: 13 additions & 15 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | | - |
4 | 3 | |
5 | | - |
| 4 | + |
| 5 | + |
6 | 6 | |
7 | | - |
8 | | - |
| 7 | + |
| 8 | + |
9 | 9 | |
10 | 10 | |
11 | | - |
12 | | - |
| 11 | + |
| 12 | + |
13 | 13 | |
14 | 14 | |
15 | | - |
16 | | - |
| 15 | + |
| 16 | + |
17 | 17 | |
18 | 18 | |
19 | 19 | |
| ||
22 | 22 | |
23 | 23 | |
24 | 24 | |
25 | | - |
| 25 | + |
| 26 | + |
| 27 | + |
26 | 28 | |
27 | 29 | |
28 | 30 | |
29 | 31 | |
| 32 | + |
| 33 | + |
30 | 34 | |
31 | 35 | |
32 | 36 | |
33 | 37 | |
34 | 38 | |
35 | 39 | |
36 | 40 | |
37 | | - |
38 | | - |
39 | | - |
40 | | - |
41 | | - |
42 | | - |
Collapse file
test/parallel/test-stream-writable-constructor-set-methods.js
Copy file name to clipboard+22-30Lines changed: 22 additions & 30 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | | - |
4 | 3 | |
5 | | - |
| 4 | + |
| 5 | + |
6 | 6 | |
7 | | - |
8 | | - |
9 | | - |
10 | | - |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
11 | 15 | |
12 | | - |
13 | | - |
| 16 | + |
14 | 17 | |
15 | | - |
16 | | - |
17 | | - |
18 | | - |
19 | | - |
20 | | - |
| 18 | + |
| 19 | + |
21 | 20 | |
22 | | - |
23 | | - |
| 21 | + |
24 | 22 | |
25 | | - |
26 | | - |
27 | | - |
| 23 | + |
| 24 | + |
| 25 | + |
28 | 26 | |
29 | | - |
| 27 | + |
30 | 28 | |
31 | | - |
| 29 | + |
| 30 | + |
| 31 | + |
32 | 32 | |
33 | 33 | |
34 | 34 | |
35 | 35 | |
36 | 36 | |
37 | | - |
38 | | - |
39 | | - |
40 | | - |
41 | | - |
42 | | - |
43 | | - |
44 | | - |
45 | | - |
| 37 | + |
0 commit comments